remove invalid fastmath usage in atan360 #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions need to be able to deal with infinities and NaNs but fastmath assumes that arguments and results are not so. On 1.12: ``` julia> Colors.atan360(-Inf, Inf) NaN ``` with fastmath removed: ``` julia> Colors.atan360(-Inf, Inf) 315.0 ``` I haven't looked into any of the other fastmath usage in this package.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 9 9
Lines 1295 1295
=======================================
Hits 1253 1253
Misses 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
An alternative is to check for the possible different Inf permutations at the beginning, similar as to how it is done with NaN. |
|
Merge? |
johnnychen94
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions need to be able to deal with infinities but fastmath assumes that arguments and results are not so.
On 1.12:
with fastmath removed:
I haven't looked into any of the other fastmath usages in this package.